jimczi commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#issuecomment-531720137 Sorry I won't have a lot of time this week to look but I think we need to find a way to benchmark this properly. No degradation in qps is one thing but if the optimization doesn't prove to be useful there is no point adding the complexity ? How did you run the benchmark, maybe you should try with wikimedium to check with bigger segments ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
