szehon-ho commented on code in PR #7933: URL: https://github.com/apache/iceberg/pull/7933#discussion_r1256605582
########## core/src/test/java/org/apache/iceberg/actions/TestCommitService.java: ########## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.actions; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.mockito.Mockito.doReturn; +import static org.mockito.Mockito.spy; + +import java.util.Set; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.TimeUnit; +import java.util.stream.IntStream; +import org.apache.iceberg.Table; +import org.apache.iceberg.TableTestBase; +import org.apache.iceberg.relocated.com.google.common.collect.Sets; +import org.apache.iceberg.util.Tasks; +import org.assertj.core.api.Assertions; +import org.awaitility.Awaitility; +import org.junit.Test; + +public class TestCommitService extends TableTestBase { + + public TestCommitService() { + super(1); + } + + @Test + public void testCommittedResultsCorrectly() { + CustomCommitService commitService = new CustomCommitService(table, 5, 10000); + commitService.start(); + + ExecutorService executorService = Executors.newFixedThreadPool(10); + Tasks.range(100).executeWith(executorService).run(commitService::offer); + commitService.close(); + + Set<Integer> expected = Sets.newHashSet(IntStream.range(0, 100).iterator()); + Set<Integer> actual = Sets.newHashSet(commitService.results()); + Assertions.assertThat(actual).isEqualTo(expected); + } + + @Test + public void testAbortFileGroupsAfterTimeout() { + CustomCommitService commitService = new CustomCommitService(table, 5, 200); + commitService.start(); + + // Add the number of less than rewritesPerCommit + for (int i = 0; i < 4; i++) { + commitService.offer(i); + } + + // Simulate the latest group of rewrite + CustomCommitService spyCommitService = spy(commitService); + doReturn(false).when(spyCommitService).canCreateCommitGroup(); Review Comment: Is it possible to make a CustomCommitServicde implement canCreateCommitGroup() with a wait/notify. (instead of using the rewritesPerCommit limit to trigger it as the same time as close, which is a bit hard to grasp). Something like: ``` CustomCommitSerivce { private boolean canCreateCommitGroup() { object.wait(); } } ... for (int i = 0; i < 4; i++) { service.submit(commitService.offer()); } commitService.close(); object.notify(); ``` I am not sure if that is what you are looking for, though, as its a bit hard for me to follow the test thought. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
