szehon-ho commented on code in PR #7933: URL: https://github.com/apache/iceberg/pull/7933#discussion_r1263050142
########## core/src/test/java/org/apache/iceberg/actions/TestCommitService.java: ########## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.actions; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.mockito.Mockito.doReturn; +import static org.mockito.Mockito.spy; + +import java.util.Set; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.TimeUnit; +import java.util.stream.IntStream; +import org.apache.iceberg.Table; +import org.apache.iceberg.TableTestBase; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableSet; +import org.apache.iceberg.relocated.com.google.common.collect.Sets; +import org.apache.iceberg.util.Tasks; +import org.assertj.core.api.Assertions; +import org.awaitility.Awaitility; +import org.junit.Test; + +public class TestCommitService extends TableTestBase { + + public TestCommitService() { + super(1); + } + + @Test + public void testCommittedResultsCorrectly() { + CustomCommitService commitService = new CustomCommitService(table, 5, 10000); + commitService.start(); + + ExecutorService executorService = Executors.newFixedThreadPool(10); + int numberOfFileGroups = 100; + Tasks.range(numberOfFileGroups).executeWith(executorService).run(commitService::offer); + commitService.close(); + + Set<Integer> expected = Sets.newHashSet(IntStream.range(0, 100).iterator()); + Set<Integer> actual = Sets.newHashSet(commitService.results()); + Assertions.assertThat(actual).isEqualTo(expected); + } + + @Test + public void testAbortFileGroupsAfterTimeout() { + CustomCommitService commitService = new CustomCommitService(table, 5, 200); + commitService.start(); + + // Add file groups [0-3] for commit. + // There are less than the rewritesPerCommit, and thus will not trigger a commit action. Those + // file groups will be added to the completedRewrites queue. + // Now the queue has 4 file groups that need to commit. + for (int i = 0; i < 4; i++) { + commitService.offer(i); + } + + // Add file groups [4-7] for commit + // These are gated to not be able to commit, so all those 4 file groups will be added to the + // queue as well. + // Now the queue has 8 file groups that need to commit. + CustomCommitService spyCommitService = spy(commitService); + doReturn(false).when(spyCommitService).canCreateCommitGroup(); + for (int i = 4; i < 8; i++) { + spyCommitService.offer(i); + } + + // close commitService. + // This allows committerService thread to start to commit the remaining file groups [0-7] in the + // completedRewrites queue. And also the main thread waits for the committerService thread to + // finish within a timeout. + + // The committerService thread commits file groups [0-4]. These will wait a fixed duration to Review Comment: Sorry yea, long day :) Saw the 0-3 up top and thought its the same -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
