skytin1004 commented on code in PR #7996:
URL: https://github.com/apache/iceberg/pull/7996#discussion_r1254107770
##########
delta-lake/src/test/java/org/apache/iceberg/delta/TestBaseSnapshotDeltaLakeTableAction.java:
##########
@@ -28,23 +28,22 @@
import org.apache.iceberg.catalog.Namespace;
import org.apache.iceberg.catalog.TableIdentifier;
import org.assertj.core.api.Assertions;
-import org.junit.Before;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
public class TestBaseSnapshotDeltaLakeTableAction {
- @Rule public TemporaryFolder temp1 = new TemporaryFolder();
- @Rule public TemporaryFolder temp2 = new TemporaryFolder();
+ @TempDir File temp1;
+ @TempDir File temp2;
private String sourceTableLocation;
private final Configuration testHadoopConf = new Configuration();
private String newTableLocation;
private final Catalog testCatalog = new TestCatalog();
- @Before
+ @BeforeEach
public void before() throws IOException {
- File sourceFolder = temp1.newFolder();
- File destFolder = temp2.newFolder();
+ File sourceFolder = temp1;
+ File destFolder = temp2;
Review Comment:
I 've removed src + dest folder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]