nastra commented on code in PR #7996:
URL: https://github.com/apache/iceberg/pull/7996#discussion_r1253302125
##########
core/src/test/java/org/apache/iceberg/avro/AvroTestHelpers.java:
##########
@@ -95,7 +94,7 @@ static void assertEquals(Types.ListType list, List<?>
expected, List<?> actual)
static void assertEquals(Types.MapType map, Map<?, ?> expected, Map<?, ?>
actual) {
Type valueType = map.valueType();
- Assert.assertEquals("Map size should match", expected.size(),
actual.size());
+ Assertions.assertThat(actual).as("Map keys should
match").hasSize(expected.size());
Review Comment:
```suggestion
Assertions.assertThat(actual).as("Map keys should
match").hasSameSizeAs(expected);
```
same for the above one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
