szehon-ho commented on code in PR #7920:
URL: https://github.com/apache/iceberg/pull/7920#discussion_r1246965318
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -275,6 +283,7 @@ static class Partition {
private int eqDeleteFileCount;
private Long lastUpdatedMs;
private Long lastUpdatedSnapshotId;
+ private long dataFileSizeInBytes;
Review Comment:
nit: can we move after dataFileCount? (as its part of 'dataFile' group)
##########
spark/v3.1/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -2028,4 +2042,10 @@ public static Dataset<Row> selectNonDerived(Dataset<Row>
metadataTable) {
public static Types.StructType nonDerivedSchema(Dataset<Row> metadataTable) {
return
SparkSchemaUtil.convert(selectNonDerived(metadataTable).schema()).asStruct();
}
+
+ private long getDataFileSizeInBytes(Iterable<DataFile> dataFiles) {
Review Comment:
nit: we can remove 'get' (Iceberg code style guideline are a bit different:
https://iceberg.apache.org/contribute/#method-naming)
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -73,6 +73,11 @@ public class PartitionsTable extends BaseMetadataTable {
"equality_delete_file_count",
Types.IntegerType.get(),
"Count of equality delete files"),
+ Types.NestedField.required(
+ 11,
+ "total_data_file_size_in_bytes",
+ Types.LongType.get(),
+ "Total bytes of data files in a partition"),
Review Comment:
nit: 'total size in bytes'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
