szehon-ho commented on code in PR #7920:
URL: https://github.com/apache/iceberg/pull/7920#discussion_r1244089947
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -82,7 +82,12 @@ public class PartitionsTable extends BaseMetadataTable {
10,
"last_updated_snapshot_id",
Types.LongType.get(),
- "Id of snapshot that last updated this partition"));
+ "Id of snapshot that last updated this partition"),
+ Types.NestedField.required(
Review Comment:
And this topic always comes up, but what do you think of the position?
@ajantha-bhat @dramaticlly . Maybe its better after file_count? (so we have 3
columns for data, pos_delete, and eq_delete)
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -82,7 +82,12 @@ public class PartitionsTable extends BaseMetadataTable {
10,
"last_updated_snapshot_id",
Types.LongType.get(),
- "Id of snapshot that last updated this partition"));
+ "Id of snapshot that last updated this partition"),
+ Types.NestedField.required(
+ 11,
+ "total_data_size_in_bytes",
Review Comment:
Ah good point, I'm ok with total_data_file_size_in_bytes then to be
consistent, initially thought its a bit long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
