nastra commented on code in PR #7838:
URL: https://github.com/apache/iceberg/pull/7838#discussion_r1229274947
##########
core/src/main/java/org/apache/iceberg/rest/requests/UpdateTableRequest.java:
##########
@@ -42,13 +46,19 @@ public UpdateTableRequest() {
// needed for Jackson deserialization
}
+ /**
+ * @deprecated will be removed in 1.5.0; use {@link
UpdateTableRequestBuilder#newBuilder()}
+ * instead.
+ */
+ @Deprecated
public UpdateTableRequest(List<UpdateRequirement> requirements,
List<MetadataUpdate> updates) {
this.requirements = requirements;
this.updates = updates;
}
+ @Constructor
Review Comment:
the constructor needs to be non-private (we could also change it to
`protected` to be more strict and force usage via the generated builder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
