nastra commented on code in PR #7838: URL: https://github.com/apache/iceberg/pull/7838#discussion_r1229268846
########## core/src/main/java/org/apache/iceberg/rest/requests/UpdateTableRequest.java: ########## @@ -31,7 +32,10 @@ import org.apache.iceberg.relocated.com.google.common.collect.Lists; import org.apache.iceberg.relocated.com.google.common.collect.Sets; import org.apache.iceberg.rest.RESTRequest; +import org.immutables.builder.Builder.Constructor; +import org.immutables.value.Value; [email protected](newBuilder = "newBuilder") Review Comment: without this, one would instantiate the Builder via `new UpdateTableRequestBuilder()`, which is probably fine as well. We could also add ``` public static UpdateTableRequestBuilder builder() { return new UpdateTableRequestBuilder(); } ``` to `UpdateTableRequest` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
