nastra commented on code in PR #7750:
URL: https://github.com/apache/iceberg/pull/7750#discussion_r1227655313
##########
core/src/main/java/org/apache/iceberg/rest/RESTSerializers.java:
##########
@@ -110,6 +118,28 @@ public void serialize(
}
}
+ public static class UpdateReqDeserializer
Review Comment:
good call, yes I think it makes sense to make these non-public.
There are some Ser/De classes that are used directly, such as
`ErrorResponseSerializer` / `ErrorResponseDeserializer`. Those are being used
in `S3ObjectMapper`. However, most others can be non-public and I've also
updated `UpdateReqDeserializer` / `UpdateReqSerializer` to non-public
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
