rdblue commented on code in PR #7750:
URL: https://github.com/apache/iceberg/pull/7750#discussion_r1226897415
##########
.palantir/revapi.yml:
##########
@@ -737,6 +737,11 @@ acceptedBreaks:
old: "method void
org.apache.iceberg.rest.auth.OAuth2Util.AuthSession::<init>(java.util.Map<java.lang.String,\
\ java.lang.String>, java.lang.String, java.lang.String)"
justification: "Removing deprecations for 1.3.0"
+ - code: "java.method.returnTypeTypeParametersChanged"
+ old: "method
java.util.List<org.apache.iceberg.rest.requests.UpdateTableRequest.UpdateRequirement>\
+ \ org.apache.iceberg.rest.requests.UpdateTableRequest::requirements()"
+ new: "method java.util.List<org.apache.iceberg.UpdateRequirement>
org.apache.iceberg.rest.requests.UpdateTableRequest::requirements()"
+ justification: "Accepted src API break by moving UpdateTableRequest out
of REST"
Review Comment:
This is only an API breaking change if we return a different implementation.
Since we are still returning `UpdateTableRequest.UpdateRequirement`, I think it
is not going to be a binary-breaking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
