Fokko commented on PR #7699: URL: https://github.com/apache/iceberg/pull/7699#issuecomment-1567524552
@rdblue Thanks for the review. Went over the comments and added extensive tests for v1 and v2 manifest-file's. The CI will fail because of: https://github.com/apache/iceberg/pull/7729 The caching logic for caching the docker image worked on the PR ([#7698](https://github.com/apache/iceberg/pull/7698)), but somehow fails on the master branch. I think the easiest way is to revert it for now. I'll open up a new PR with the changes and also refactoring of the caching logic (I don't like it, way to complicated). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
