Fokko commented on code in PR #7699:
URL: https://github.com/apache/iceberg/pull/7699#discussion_r1209558572
##########
python/tests/utils/test_manifest.py:
##########
@@ -191,9 +191,9 @@ def test_read_manifest(generated_manifest_file_file: str)
-> None:
assert manifest_list.manifest_length == 7989
assert manifest_list.partition_spec_id == 0
- assert manifest_list.content is None
- assert manifest_list.sequence_number is None
- assert manifest_list.min_sequence_number is None
+ assert manifest_list.content == 0
Review Comment:
This will go well for a long time:
```python
➜ python git:(fd-initial-default) ✗ python3
Python 3.11.3 (main, Apr 7 2023, 20:13:31) [Clang 14.0.0
(clang-1400.0.29.202)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from pyiceberg.manifest import ManifestContent
>>> ManifestContent.DATA == 0
True
>>> ManifestContent.DATA == 1
False
>>> 1 == ManifestContent.DATA
False
```
But you're right and this should be an enum, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
