flyrain commented on PR #7649: URL: https://github.com/apache/iceberg/pull/7649#issuecomment-1564710948
Merged. Thanks @CodingCat for the change. > what i mean was that if we move commitOperation to a base class, can we guarantee we always call the base class's commitOperation in future? (probably hard to make such a commitment, but that would break the effort of refactoring again) Not sure how it looks finally, but worth to have a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
