CodingCat commented on PR #7649: URL: https://github.com/apache/iceberg/pull/7649#issuecomment-1563286666
> > IIUC, you mean we move the code consuming CommitMetadata to a base class so that we will not fall into the situation like this PR tries to address? > > Exactly. We can refactor later. I'm OK with a quick fix like this. > > > (2) in future, can we guarantee to use the same commit implementation for all snapshot producers (at least in Spark)? > > I'm not sure if I got you correctly. I assume we do need the same implementation. Any concern? what i mean was that if we move `commitOperation` to a base class, can we guarantee we always call the base class's commitOperation in future? (probably hard to make such a commitment, but that would break the effort of refactoring again) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
