aokolnychyi commented on code in PR #7703:
URL: https://github.com/apache/iceberg/pull/7703#discussion_r1205988701


##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -283,8 +283,13 @@ DistributionMode copyOnWriteDistributionMode(Command 
command) {
   }
 
   public SparkWriteRequirements positionDeltaRequirements(Command command) {
+    if (ignoreTableDistributionAndOrdering()) {

Review Comment:
   Matches CoW and insert requirements now.



##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -283,8 +283,13 @@ DistributionMode copyOnWriteDistributionMode(Command 
command) {
   }
 
   public SparkWriteRequirements positionDeltaRequirements(Command command) {
+    if (ignoreTableDistributionAndOrdering()) {

Review Comment:
   Matches CoW and insert requirements now (defined above).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to