ConeyLiu commented on code in PR #7693:
URL: https://github.com/apache/iceberg/pull/7693#discussion_r1205049115
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRequiredDistributionAndOrdering.java:
##########
@@ -268,6 +268,23 @@ public void testDefaultSortOnLongTruncatedColumn() {
assertEquals("Rows must match", expected, sql("SELECT * FROM %s ORDER BY
c1", tableName));
}
+ @Test
+ public void testDefaultSortOnBinaryColumn() {
Review Comment:
Hi @jzhuge, I checked the `TestRequiredDistributionAndOrdering ` again, it
seems the new UT would be more reasonable to put here. You could see the around
UTs all are about partition and ordering tests. I renamed the UT name from
`testDefaultSortOnBinaryColumn ` to `testDefaultSortOnBinaryBucketedColumn` to
keep the name consistent with others. However, I could move it if you stand by
your point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
