jzhuge commented on code in PR #7693:
URL: https://github.com/apache/iceberg/pull/7693#discussion_r1204997353
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRequiredDistributionAndOrdering.java:
##########
@@ -268,6 +268,23 @@ public void testDefaultSortOnLongTruncatedColumn() {
assertEquals("Rows must match", expected, sql("SELECT * FROM %s ORDER BY
c1", tableName));
}
+ @Test
+ public void testDefaultSortOnBinaryColumn() {
Review Comment:
Yes, it is the unit test. However, what do you think if we move it from
TestRequiredDistributionAndOrdering.java to TestIcebergExpressions.java? I feel
the later test source file is a more place to add the unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
