huaxingao commented on code in PR #7636:
URL: https://github.com/apache/iceberg/pull/7636#discussion_r1199558579
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -376,6 +363,12 @@ public Scan build() {
}
private Scan buildBatchScan() {
+ Schema expectedSchema = schemaWithMetadataColumns();
+ return new SparkBatchQueryScan(
+ spark, table, buildIcebergBatchScan(false), readConf, expectedSchema,
filterExpressions);
+ }
+
+ private org.apache.iceberg.Scan buildIcebergBatchScan(boolean withStats) {
Review Comment:
Yea, we need the fully qualified type because we have already `import
org.apache.spark.sql.connector.read.Scan`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
