RussellSpitzer commented on code in PR #7636:
URL: https://github.com/apache/iceberg/pull/7636#discussion_r1198006855
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -221,15 +222,26 @@ public boolean pushAggregation(Aggregation aggregation) {
return false;
}
- TableScan scan = table.newScan().includeColumnStats();
- Snapshot snapshot = readSnapshot();
- if (snapshot == null) {
- LOG.info("Skipping aggregate pushdown: table snapshot is null");
- return false;
+ org.apache.iceberg.Scan scan;
Review Comment:
Look further, we already have a build scan procedure for normal scans, why
don't we use those private functions? or extract that logic?
Like buildBatchScan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
