szehon-ho commented on code in PR #7630:
URL: https://github.com/apache/iceberg/pull/7630#discussion_r1198124877
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -159,26 +161,25 @@ public RewriteDataFiles.Result execute() {
validateAndInitOptions();
- Map<StructLike, List<List<FileScanTask>>> fileGroupsByPartition =
+ StructLikeMap<List<List<FileScanTask>>> fileGroupsByPartition =
planFileGroups(startingSnapshotId);
RewriteExecutionContext ctx = new
RewriteExecutionContext(fileGroupsByPartition);
if (ctx.totalGroupCount() == 0) {
LOG.info("Nothing found to rewrite in {}", table.name());
- return
ImmutableRewriteDataFiles.Result.builder().rewriteResults(ImmutableList.of()).build();
+ return EMPTY_RESULT;
}
Stream<RewriteFileGroup> groupStream = toGroupStream(ctx,
fileGroupsByPartition);
- RewriteDataFilesCommitManager commitManager =
commitManager(startingSnapshotId);
if (partialProgressEnabled) {
- return doExecuteWithPartialProgress(ctx, groupStream, commitManager);
+ return doExecuteWithPartialProgress(ctx, groupStream,
commitManager(startingSnapshotId));
Review Comment:
I guess i'd personally put the variable back, as in the
RewriteDeleteFilesSparkAction case it was just a call without arguments, but
here there are arguments so probably is more clearer if we assign it
separately, but not a big deal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
