ajantha-bhat commented on code in PR #7630:
URL: https://github.com/apache/iceberg/pull/7630#discussion_r1197398322
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -235,6 +199,37 @@ Map<StructLike, List<List<FileScanTask>>>
planFileGroups(long startingSnapshotId
}
}
+ private StructLikeMap<List<FileScanTask>> groupByPartition(
+ StructType partitionType, Iterable<FileScanTask> tasks) {
+ StructLikeMap<List<FileScanTask>> filesByPartition =
StructLikeMap.create(partitionType);
Review Comment:
Thats strange. So, we don't have enough testcases to catch this behaviour?
I have reverted it back now. Also, I didn't use `transform` in the end of
`planFileGroups` because it needs a special check of `fileGroups.size() > 0`
which is not handled in transform due to generics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
