rdblue commented on code in PR #7487:
URL: https://github.com/apache/iceberg/pull/7487#discussion_r1194522415
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -485,8 +505,13 @@ private ScheduledExecutorService tokenRefreshExecutor() {
public void close() throws IOException {
shutdownRefreshExecutor();
- if (client != null) {
- client.close();
+ if (closeableGroup != null) {
+ closeableGroup.close();
+ }
+
+ if (fileIOCloser != null) {
+ fileIOCloser.cleanUp();
+ fileIOCloser.invalidateAll();
Review Comment:
@nastra, this is the only remaining issue. I looked at Caffeine and I think
this is backwards. Calling `invalidateAll` will remove all entries and
`cleanUp` will handle any remaining deferred work. Removing entries can create
deferred work in some cases so I think that we need to invalidate and then
clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
