rdblue commented on code in PR #7487:
URL: https://github.com/apache/iceberg/pull/7487#discussion_r1183896913
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -339,25 +350,34 @@ public Table loadTable(SessionContext context,
TableIdentifier identifier) {
}
RESTTableOperations ops =
- new RESTTableOperations(
- client,
- paths.table(loadedIdent),
- session::headers,
- tableFileIO(context, response.config()),
- tableMetadata);
+ withFileIOTracking(
+ new RESTTableOperations(
+ client,
+ paths.table(finalIdentifier),
+ session::headers,
+ tableFileIO(context, response.config()),
+ tableMetadata));
BaseTable table =
new BaseTable(
ops,
- fullTableName(loadedIdent),
- metricsReporter(paths.metrics(loadedIdent), session::headers));
+ fullTableName(finalIdentifier),
+ metricsReporter(paths.metrics(finalIdentifier), session::headers));
if (metadataType != null) {
return MetadataTableUtils.createMetadataTableInstance(table,
metadataType);
}
return table;
}
+ private RESTTableOperations withFileIOTracking(RESTTableOperations ops) {
Review Comment:
As I noted below, I think this should not pass through `ops`. In that case,
it makes more sense to name it something like `registerFileIO` or `trackFileIO`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
