szehon-ho commented on code in PR #7551:
URL: https://github.com/apache/iceberg/pull/7551#discussion_r1191689218
##########
core/src/test/java/org/apache/iceberg/TestMetadataTableScansWithPartitionEvolution.java:
##########
@@ -222,6 +222,14 @@ public void testPositionDeletesPartitionSpecRemoval() {
constantsMap(posDeleteTask,
partitionType).get(MetadataColumns.FILE_PATH.fieldId()));
}
+ @Test
+ public void testPartitionSpecEvolutionToUnpartitioned() {
Review Comment:
Hm. it looks a bit long :) In that case, Id vote to maybe bring back the
original asserts then the first commit so its a more end-to-end test and we
dont have to change the name too much ,
https://github.com/apache/iceberg/pull/7551/commits/54b95ea8658d7db03eea717e68b09350fff13a9a
as I dont think its covered elsewhere (though realize its not related to this
pr )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
