ajantha-bhat commented on code in PR #7551:
URL: https://github.com/apache/iceberg/pull/7551#discussion_r1190739364
##########
core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java:
##########
@@ -805,6 +807,47 @@ public void testPartitionSpecEvolutionRemoval() {
}
}
+ @Test
+ public void testPartitionSpecEvolutionToUnpartitioned() throws IOException {
Review Comment:
I moved it now.
> Also another question, does this test the case? I thought it was only
failing on V2, because I had seen on V1 the partition transform remains as void
on the latest spec, when removed.
Yes, the testcase fails only for v2 without the PR changes as V1 will have
void transform to satisfy the check. But I thought it can run for both.
BTW, now I removed the scan code in the testcase because my intention was to
just scan spec_id column and see it is filled instead of null. But I don't know
how to achieve it (In sql or spark code I know. But in this table scan I am not
sure as instead of rows it returns content files)
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -36,6 +36,8 @@ public class PartitionsTable extends BaseMetadataTable {
private final Schema schema;
+ private final boolean isUnpartitionedTable;
Review Comment:
updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
