stevenzwu commented on code in PR #7494:
URL: https://github.com/apache/iceberg/pull/7494#discussion_r1191663833
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/DataStatisticsOperator.java:
##########
@@ -132,19 +130,19 @@ public void snapshotState(StateSnapshotContext context)
throws Exception {
// For now, we make it simple to send globalStatisticsState at checkpoint
operatorEventGateway.sendEventToCoordinator(
- new DataStatisticsEvent<>(checkpointId, localStatistics));
+ new DataStatisticsEvent(checkpointId, localStatistics));
// Recreate the local statistics
- localStatistics = statisticsFactory.createDataStatistics();
+ localStatistics = statisticsSerializer.createInstance();
}
@VisibleForTesting
- DataStatistics<K> localDataStatistics() {
+ DataStatistics localDataStatistics() {
return localStatistics;
}
@VisibleForTesting
- DataStatistics<K> globalDataStatistics() {
+ DataStatistics globalDataStatistics() {
Review Comment:
good batch. will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
