stevenzwu commented on code in PR #7494:
URL: https://github.com/apache/iceberg/pull/7494#discussion_r1184504748


##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle/DataStatisticsOperator.java:
##########
@@ -40,50 +40,49 @@
  * shuffle record to improve data clustering while maintaining relative 
balanced traffic
  * distribution to downstream subtasks.
  */
-class DataStatisticsOperator<T, K> extends 
AbstractStreamOperator<DataStatisticsOrRecord<T, K>>
-    implements OneInputStreamOperator<T, DataStatisticsOrRecord<T, K>>, 
OperatorEventHandler {
+class DataStatisticsOperator<D extends DataStatistics<D, S>, S>

Review Comment:
   Yes, this is only for collecting statistics to guide the partitioner 
decision. we will implement a custom range partitioner (Flink )  that splits 
the value into ranges (one for each assigner writer subtask) based on the 
statistics.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to