aokolnychyi commented on code in PR #7555:
URL: https://github.com/apache/iceberg/pull/7555#discussion_r1188005697


##########
api/src/main/java/org/apache/iceberg/ContentFile.java:
##########
@@ -113,6 +113,16 @@ default Integer sortOrderId() {
     return null;
   }
 
+  /** Returns the data sequence number of the snapshot in which the file 
should be applied. */

Review Comment:
   What about something like this?
   
   ```
   /**
    * Returns the data sequence number of the file.
    *
    * <p>This method represents the sequence number to which the file should 
apply. Note the data
    * sequence number may differ from the sequence number of the snapshot in 
which the underlying
    * file was added. New snapshots can add files that belong to older sequence 
numbers (e.g.
    * compaction). The data sequence number also does not change when the file 
is marked as deleted.
    *
    * <p>This method can return null if the data sequence number is unknown. 
This may happen while
    * reading a v2 manifest that did not persist the data sequence number for 
manifest entries with
    * status DELETED (older Iceberg versions).
    */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to