aokolnychyi commented on code in PR #7555:
URL: https://github.com/apache/iceberg/pull/7555#discussion_r1188003885
##########
api/src/main/java/org/apache/iceberg/ContentFile.java:
##########
@@ -113,6 +113,16 @@ default Integer sortOrderId() {
return null;
}
+ /** Returns the data sequence number of the snapshot in which the file
should be applied. */
+ default Long dataSequenceNumber() {
+ return null;
+ }
+
+ /** Returns the file sequence number. */
Review Comment:
We, probably, need to add more context on what this sequence number
represents given that it is a public API. What about something like this?
```
/**
* Returns the file sequence number.
*
* <p>The file sequence number represents the sequence number of the
snapshot in which the
* underlying file was added. The file sequence number is always assigned at
commit and cannot be
* provided explicitly, unlike the data sequence number. The file sequence
number does not change
* upon assigning.
*
* <p>This method can return null if the file sequence number is unknown.
This may happen while
* reading a v2 manifest that did not persist the file sequence number for
manifest entries with
* status EXISTING or DELETED (older Iceberg versions).
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
