rdblue commented on code in PR #7536:
URL: https://github.com/apache/iceberg/pull/7536#discussion_r1186260114
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -186,4 +194,19 @@ private static String scheme(String location) {
return null;
}
+
+ @SuppressWarnings("checkstyle:NoFinalizer")
+ @Override
+ protected void finalize() throws Throwable {
Review Comment:
@snazy, we know.
Iceberg uses this pattern to ensure that close is called. We also log the
stack trace at WARN so that we can track down leaks. It is better to close in a
finalizer than to not close at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
