Fokko commented on code in PR #7519:
URL: https://github.com/apache/iceberg/pull/7519#discussion_r1185284310


##########
python/pyiceberg/catalog/rest.py:
##########
@@ -172,8 +175,6 @@ class OAuthErrorResponse(IcebergBaseModel):
 
 class RestCatalog(Catalog):
     uri: str
-    session: Session

Review Comment:
   Yes the `attr: str` in:
   
   ```python
   class A:
       attr: str
   ```
   
   is just syntactical sugar, and will not be there until it is assigned. If 
you assign a value to it directly, it won't throw an `AttributeError`.
   
   ```
   ➜  trino git:(master) ✗ python3
   Python 3.11.3 (main, Apr  7 2023, 20:13:31) [Clang 14.0.0 
(clang-1400.0.29.202)] on darwin
   Type "help", "copyright", "credits" or "license" for more information.
   >>> class A:
   ...     attr: str = ""
   ... 
   >>> A().attr
   ''
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to