stevenzwu commented on code in PR #7493:
URL: https://github.com/apache/iceberg/pull/7493#discussion_r1183232770
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/data/RowDataProjection.java:
##########
@@ -166,7 +169,8 @@ public int getArity() {
@Override
public RowKind getRowKind() {
- return rowData.getRowKind();
+ // rowData can be null for nested struct
Review Comment:
Dug out this issue: https://github.com/apache/iceberg/issues/2738
If the nested struct is null, right now both StructProjection and
RowDataProjection returns a Projection object wrapping a null struct. I
actually think it is probably better to just return a null Projection object in
this case.
Let me create a separate issue to follow up on this and see if the community
agrees with the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
