stevenzwu commented on code in PR #7493:
URL: https://github.com/apache/iceberg/pull/7493#discussion_r1181953434
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/DataGenerators.java:
##########
@@ -81,7 +81,7 @@ public static class Primitives implements DataGenerator {
private final Schema icebergSchema =
new Schema(
- Types.NestedField.required(1, "partition_field",
Types.StringType.get()),
+ Types.NestedField.required(1, "row_id", Types.StringType.get()),
Review Comment:
renaming the field id to also match what the `RowDataProjection` usage (like
`idOnly` projected schema)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
