Fokko commented on issue #7458:
URL: https://github.com/apache/iceberg/issues/7458#issuecomment-1527894463
Hey @DarthData410 thanks for picking this up! Always great to have new folks
joining the project. Thanks for resolving them in `conversion.py`. The end goal
is to fix all the warnings and enable `--strict` mode. This will fail on any
errors. I've updated the ticket above.
```
➜ mkdocs git:(fd-alter-table) mkdocs serve -a localhost:1815
INFO - Building documentation...
INFO - Cleaning site directory
INFO - DeprecationWarning: The `griffe.agents.extensions` module is
deprecated in favor of the `griffe.extensions` module. Please import from the
new module instead.
File
"/opt/homebrew/lib/python3.11/site-packages/mkdocstrings_handlers/python/handler.py",
line 14, in <module>
from griffe.agents.extensions import load_extensions
File
"/opt/homebrew/lib/python3.11/site-packages/griffe/agents/extensions.py", line
10, in __getattr__
warnings.warn(
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/schema.py:695: No type
or annotation for parameter 'container(StructProtocol)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/schema.py:695:
Parameter 'container(StructProtocol)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/schema.py:786:
Parameter 'obj(Schema' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/schema.py:717:
Parameter 'obj(Schema' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/transforms.py:712:
Parameter 'source_type' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/types.py:442: Confusing
indentation for continuation line 13 in docstring, should be 4 * 2 = 8 spaces,
not 6
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/types.py:444: Confusing
indentation for continuation line 15 in docstring, should be 4 * 2 = 8 spaces,
not 6
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/types.py:392: Confusing
indentation for continuation line 11 in docstring, should be 4 * 2 = 8 spaces,
not 6
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/types.py:394: Confusing
indentation for continuation line 13 in docstring, should be 4 * 2 = 8 spaces,
not 6
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/types.py:418: Confusing
indentation for continuation line 15 in docstring, should be 4 * 2 = 8 spaces,
not 6
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/types.py:420: Confusing
indentation for continuation line 17 in docstring, should be 4 * 2 = 8 spaces,
not 6
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/expressions/literals.py:116:
Parameter 'value(Python' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/expressions/visitors.py:146:
No type or annotation for parameter 'obj(BooleanExpression)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/expressions/visitors.py:146:
Parameter 'obj(BooleanExpression)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/expressions/visitors.py:147:
No type or annotation for parameter 'visitor(BooleanExpressionVisitor[T])'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/expressions/visitors.py:147:
Parameter 'visitor(BooleanExpressionVisitor[T])' does not appear in the
function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/__init__.py:246:
Parameter 'location(str,' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/__init__.py:247:
Failed to get 'name: description' pair from 'an OutputFile instance is
provided, the location attribute
for that instance is used as the URI to delete'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/__init__.py:230: No
type or annotation for parameter 'location(str)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/__init__.py:230:
Parameter 'location(str)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/__init__.py:238: No
type or annotation for parameter 'location(str)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/__init__.py:238:
Parameter 'location(str)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/__init__.py:120: No
type or annotation for parameter 'location(str)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/__init__.py:120:
Parameter 'location(str)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/__init__.py:168: No
type or annotation for parameter 'location(str)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/__init__.py:168:
Parameter 'location(str)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/__init__.py:205: No
type or annotation for parameter 'overwrite(bool)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/__init__.py:205:
Parameter 'overwrite(bool)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/__init__.py:206:
Failed to get 'name: description' pair from 'and `overwrite` is False a
FileExistsError should be
raised'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/fsspec.py:282:
Parameter 'location(str,' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/fsspec.py:283:
Failed to get 'name: description' pair from 'OutputFile instance is provided,
the location attribute for
that instance is used as the location'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/fsspec.py:284:
Failed to get 'name: description' pair from 'to delete'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/fsspec.py:256: No
type or annotation for parameter 'location(str)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/fsspec.py:256:
Parameter 'location(str)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/fsspec.py:269: No
type or annotation for parameter 'location(str)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/fsspec.py:269:
Parameter 'location(str)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/fsspec.py:151: No
type or annotation for parameter 'location(str)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/fsspec.py:151:
Parameter 'location(str)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/fsspec.py:152: No
type or annotation for parameter 'fs(AbstractFileSystem)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/fsspec.py:152:
Parameter 'fs(AbstractFileSystem)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/fsspec.py:195: No
type or annotation for parameter 'location(str)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/fsspec.py:195:
Parameter 'location(str)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/fsspec.py:196: No
type or annotation for parameter 'fs(AbstractFileSystem)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/fsspec.py:196:
Parameter 'fs(AbstractFileSystem)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/fsspec.py:220: No
type or annotation for parameter 'overwrite(bool)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/fsspec.py:220:
Parameter 'overwrite(bool)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:131: No
type or annotation for parameter 'location(str)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:131:
Parameter 'location(str)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:225: No
type or annotation for parameter 'overwrite(bool)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:225:
Parameter 'overwrite(bool)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:318:
Parameter 'location(str,' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:319:
Failed to get 'name: description' pair from 'OutputFile instance is provided,
the location attribute for
that instance is used as the location'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:320:
Failed to get 'name: description' pair from 'to delete'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:292: No
type or annotation for parameter 'location(str)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:292:
Parameter 'location(str)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:305: No
type or annotation for parameter 'location(str)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:305:
Parameter 'location(str)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:561: No
type or annotation for parameter 'tasks(Iterable[FileScanTask])'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:561:
Parameter 'tasks(Iterable[FileScanTask])' does not appear in the function
signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:562: No
type or annotation for parameter 'table(Table)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:562:
Parameter 'table(Table)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:563: No
type or annotation for parameter 'row_filter(BooleanExpression)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:563:
Parameter 'row_filter(BooleanExpression)' does not appear in the function
signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:564: No
type or annotation for parameter 'projected_schema(Schema)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:564:
Parameter 'projected_schema(Schema)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:565: No
type or annotation for parameter 'case_sensitive(bool)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/io/pyarrow.py:565:
Parameter 'case_sensitive(bool)' does not appear in the function signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/table/sorting.py:118:
Parameter 'order_id' does not appear in the function signature
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
