Fokko opened a new issue, #7458:
URL: https://github.com/apache/iceberg/issues/7458
### Feature Request / Improvement
It looks like there are some warnings thrown when we run mkdocs that we can
easily fix:
```
➜ mkdocs git:(fd-alter-table) ✗ mkdocs serve -a localhost:1815
INFO - Building documentation...
INFO - Cleaning site directory
INFO - DeprecationWarning: The `griffe.agents.extensions` module is
deprecated in favor of the `griffe.extensions` module. Please import from the
new module instead.
File
"/opt/homebrew/lib/python3.11/site-packages/mkdocstrings_handlers/python/handler.py",
line 14, in <module>
from griffe.agents.extensions import load_extensions
File
"/opt/homebrew/lib/python3.11/site-packages/griffe/agents/extensions.py", line
10, in __getattr__
warnings.warn(
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/conversions.py:249: No
type or annotation for parameter 'primitive_type(PrimitiveType)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/conversions.py:249:
Parameter 'primitive_type(PrimitiveType)' does not appear in the function
signature
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/conversions.py:250: No
type or annotation for parameter 'b(bytes)'
WARNING - griffe:
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/conversions.py:250:
Parameter 'b(bytes)' does not appear in the function signature
```
It looks like there is a space missing:
```python
@singledispatch
def from_bytes(primitive_type: PrimitiveType, b: bytes) -> L:
"""A generic function which converts bytes to a built-in python value
Args:
primitive_type(PrimitiveType): An implementation of the
PrimitiveType base class
b(bytes): The bytes to convert
"""
raise TypeError(f"Cannot deserialize bytes, type {primitive_type} not
supported: {str(b)}")
```
It should be:
```python
@singledispatch
def from_bytes(primitive_type: PrimitiveType, b: bytes) -> L:
"""A generic function which converts bytes to a built-in python value
Args:
primitive_type (PrimitiveType): An implementation of the
PrimitiveType base class
b (bytes): The bytes to convert
"""
raise TypeError(f"Cannot deserialize bytes, type {primitive_type} not
supported: {str(b)}")
```
### Query engine
Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
