nastra commented on code in PR #5984:
URL: https://github.com/apache/iceberg/pull/5984#discussion_r1179242822
##########
core/src/main/java/org/apache/iceberg/TableScanContext.java:
##########
@@ -96,6 +96,9 @@ public MetricsReporter metricsReporter() {
return LoggingMetricsReporter.instance();
}
+ @Nullable
+ public abstract String branch();
Review Comment:
what I mean is: we are expressing that incremental scans work on branches
through `IncrementalScan.useBranch()`, which is the publicly exposed API and
the correct thing to do.
My thinking is that `TableScanContext` is rather an internal API and is also
used in other places where don't need the distinction between branch/tag. So in
order to not limit ourselves in this internal API, I think it makes more sense
to name it `ref()` in `TableScanContext`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
