nastra commented on code in PR #5984:
URL: https://github.com/apache/iceberg/pull/5984#discussion_r1177728250
##########
core/src/main/java/org/apache/iceberg/TableScanContext.java:
##########
@@ -110,7 +114,30 @@ TableScanContext useSnapshotId(Long scanSnapshotId) {
toSnapshotId,
planExecutor,
fromSnapshotInclusive,
- metricsReporter);
+ metricsReporter,
+ branch);
+ }
+
+ String branch() {
+ return branch;
+ }
+
+ TableScanContext useBranch(String newBranch) {
Review Comment:
I simplified `TableScanContext` a while ago in
https://github.com/apache/iceberg/pull/5985 mainly because it's painful to add
a single new field (because it requires adjusting all constructor calls). I
wonder if it's worth re-visiting #5985 now
##########
.palantir/revapi.yml:
##########
@@ -1,4 +1,18 @@
acceptedBreaks:
+ "1.3.0":
+ org.apache.iceberg:iceberg-api:
+ - code: "java.method.addedToInterface"
+ new: "method ThisT org.apache.iceberg.IncrementalScan<ThisT, T extends
org.apache.iceberg.ScanTask, G extends org.apache.iceberg.ScanTaskGroup<T
extends org.apache.iceberg.ScanTask>>::useBranch(java.lang.String)"
Review Comment:
rather than breaking the API, can we make those methods `default` and throw
an `UnsupportedOperationException`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
