nastra commented on code in PR #7310:
URL: https://github.com/apache/iceberg/pull/7310#discussion_r1169566618
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestCachedClientPool.java:
##########
@@ -46,6 +46,10 @@ public void testClientPoolCleaner() throws
InterruptedException {
Assert.assertNull(
CachedClientPool.clientPoolCache()
.getIfPresent(CachedClientPool.extractKey(null, hiveConf)));
+
+ // The client has been really closed.
+ Assert.assertTrue(clientPool1.isClosed());
Review Comment:
I've checked this when reviewing and the test fails on master with these 2
checks added. However, the test passes with some wait time
```
Awaitility.await()
.atMost(10, TimeUnit.SECONDS)
.untilAsserted(
() -> {
Assert.assertTrue(clientPool1.isClosed());
Assert.assertTrue(clientPool2.isClosed());
});
```
because cache removal will eventually be executed (just not immediately).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
