pvary commented on code in PR #7310:
URL: https://github.com/apache/iceberg/pull/7310#discussion_r1169469984
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestCachedClientPool.java:
##########
@@ -46,6 +46,10 @@ public void testClientPoolCleaner() throws
InterruptedException {
Assert.assertNull(
CachedClientPool.clientPoolCache()
.getIfPresent(CachedClientPool.extractKey(null, hiveConf)));
+
+ // The client has been really closed.
+ Assert.assertTrue(clientPool1.isClosed());
Review Comment:
Just for the record: Did we test that this test fails without the fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
