RussellSpitzer commented on code in PR #6886:
URL: https://github.com/apache/iceberg/pull/6886#discussion_r1166961966
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestCreateTable.java:
##########
@@ -341,4 +343,42 @@ public void
testDowngradeTableToFormatV1ThroughTablePropertyFails() {
"Cannot downgrade v2 table to v1",
() -> sql("ALTER TABLE %s SET TBLPROPERTIES ('format-version'='1')",
tableName));
}
+
+ @Test
+ public void testCatalogSpecificWarehouseLocation() throws Exception {
+ File warehouseLocation = temp.newFolder(catalogName);
+ Assert.assertTrue(warehouseLocation.delete());
+ String location = "file:" + warehouseLocation.getAbsolutePath();
+ spark.conf().set("spark.sql.catalog." + catalogName + ".warehouse",
location);
+ String testNameSpace =
+ (catalogName.equals("spark_catalog") ? "" : catalogName + ".") +
"default1";
+ String testTableName = testNameSpace + ".table";
+ TableIdentifier newTableIdentifier = TableIdentifier.of("default1",
"table");
+
+ sql("CREATE NAMESPACE IF NOT EXISTS %s", testNameSpace);
Review Comment:
If the default always has a URI then by all means lets do this, also let's
bump this into a "before all" method for the test suite, I don't think we need
to call it for every test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
