RussellSpitzer commented on code in PR #6886:
URL: https://github.com/apache/iceberg/pull/6886#discussion_r1164364409
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestCreateTable.java:
##########
@@ -341,4 +343,42 @@ public void
testDowngradeTableToFormatV1ThroughTablePropertyFails() {
"Cannot downgrade v2 table to v1",
() -> sql("ALTER TABLE %s SET TBLPROPERTIES ('format-version'='1')",
tableName));
}
+
+ @Test
+ public void testCatalogSpecificWarehouseLocation() throws Exception {
+ File warehouseLocation = temp.newFolder(catalogName);
+ Assert.assertTrue(warehouseLocation.delete());
+ String location = "file:" + warehouseLocation.getAbsolutePath();
+ spark.conf().set("spark.sql.catalog." + catalogName + ".warehouse",
location);
+ String testNameSpace =
+ (catalogName.equals("spark_catalog") ? "" : catalogName + ".") +
"default1";
+ String testTableName = testNameSpace + ".table";
+ TableIdentifier newTableIdentifier = TableIdentifier.of("default1",
"table");
+
+ sql("CREATE NAMESPACE IF NOT EXISTS %s", testNameSpace);
+ sql("CREATE TABLE %s " + "(id BIGINT NOT NULL, data STRING) " + "USING
iceberg", testTableName);
+
+ Table table = Spark3Util.loadIcebergCatalog(spark,
catalogName).loadTable(newTableIdentifier);
+ if ("spark_catalog".equals(catalogName)) {
+
Assert.assertTrue(table.location().startsWith(spark.sqlContext().conf().warehousePath()));
Review Comment:
So two things here
1. I don't follow why "spark_catalog" should be any different here since we
are still using our SparkSessionCatalog class.
2. We need to make sure that the prefix and suffix are correct in the path.
It should start with our specified location and end with our db + tb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
