abmo-x commented on code in PR #7275:
URL: https://github.com/apache/iceberg/pull/7275#discussion_r1159116353
##########
api/src/main/java/org/apache/iceberg/catalog/SessionCatalog.java:
##########
@@ -309,6 +309,17 @@ default List<Namespace> listNamespaces(SessionContext
context) {
*/
boolean dropNamespace(SessionContext context, Namespace namespace);
+ /**
+ * Drop a namespace. If the namespace exists and was dropped, this will
return true.
+ *
+ * @param context session context
+ * @param namespace a {@link Namespace namespace}
+ * @param cascade – When true, deletes all objects under the namespace
Review Comment:
@RussellSpitzer documented the current purge behavior in the PR description
and docs.
Only Hive catalog purges the tables as that's the default behavior of hive
when we pass the cascade=true parameter.
I can make it consistent across all catalogs and modify current hive catalog
behavior to just drop table without purge similar to other catalogs. Let me
know your thoughts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
