abmo-x commented on code in PR #7275:
URL: https://github.com/apache/iceberg/pull/7275#discussion_r1157912588
##########
api/src/main/java/org/apache/iceberg/catalog/SessionCatalog.java:
##########
@@ -309,6 +309,17 @@ default List<Namespace> listNamespaces(SessionContext
context) {
*/
boolean dropNamespace(SessionContext context, Namespace namespace);
+ /**
+ * Drop a namespace. If the namespace exists and was dropped, this will
return true.
+ *
+ * @param context session context
+ * @param namespace a {@link Namespace namespace}
+ * @param cascade – When true, deletes all objects under the namespace
Review Comment:
I think we have two options, drop_namespace with cascade will:
1) drop the tables not the data (no purge)
2) drop the tables and delete the data (purge)
We can standardize this in Iceberg and go with the preferred option, #1
sounds better as #2 can take a long time depending on number of tables and data
in them. This behavior is not consistent across all catalogs, for example hive
metastore cascade deletes all the data (purge) in tables where as others don't.
should I create a vote thread for this to decide on the preference or can we
decide that in this PR? I can then update the implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
