jackye1995 commented on code in PR #3249:
URL: https://github.com/apache/iceberg/pull/3249#discussion_r1146823410
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java:
##########
@@ -95,8 +111,12 @@ public NullabilityHolder nullabilityHolder() {
return nullabilityHolder;
}
- public Type icebergType() {
Review Comment:
this incurs a change of public method, which might not be preferred. Instead
of using
```
private final Type physicalType;
private final Type logicalType;
```
can we use
```
private final Type icebergType;
private final Type logicalType;
```
which also matches later changes better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
