jackye1995 commented on code in PR #3249:
URL: https://github.com/apache/iceberg/pull/3249#discussion_r1146817959
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorHolder.java:
##########
@@ -43,17 +44,30 @@ public VectorHolder(
Dictionary dictionary,
NullabilityHolder holder,
Type type) {
+ this(columnDescriptor, vector, isDictionaryEncoded, dictionary, holder,
type, type);
+ }
+
+ public VectorHolder(
+ ColumnDescriptor columnDescriptor,
+ FieldVector vector,
+ boolean isDictionaryEncoded,
+ Dictionary dictionary,
+ NullabilityHolder holder,
+ Type type,
Review Comment:
nit: can we name this `physicalType` matching the instance variable name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
