aokolnychyi commented on code in PR #6919:
URL: https://github.com/apache/iceberg/pull/6919#discussion_r1144221538
##########
.palantir/revapi.yml:
##########
@@ -66,6 +66,9 @@ acceptedBreaks:
old: "method void org.apache.iceberg.io.DataWriter<T>::add(T)"
justification: "Removing deprecated method"
"1.1.0":
+ org.apache.iceberg:iceberg-api:
+ - code: "java.method.addedToInterface"
+ justification: "Add metricsreporter to Scan"
Review Comment:
Instead of modifying checks, we should throw `UnsupportedOperationException`
in the default implementation. Just like we do in some methods in `TableScan`
today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
