aokolnychyi commented on code in PR #6919:
URL: https://github.com/apache/iceberg/pull/6919#discussion_r1137783288
##########
api/src/main/java/org/apache/iceberg/Table.java:
##########
@@ -48,6 +49,18 @@ default String name() {
*/
TableScan newScan();
+ /**
+ * Create a new {@link TableScan scan} for this table with a {@link
MetricsReporter metrics
+ * reporter}.
+ *
+ * <p>Once a table scan is created, it can be refined to project columns and
filter data.
+ *
+ * @return a table scan for this table
+ */
+ default TableScan newScan(MetricsReporter metricsReporter) {
Review Comment:
Instead of modifying `Table`, we should probably extend `Scan` to accept any
number of custom metrics report in addition to the default one. It should
behave like a listener pattern.
##########
api/src/main/java/org/apache/iceberg/Table.java:
##########
@@ -48,6 +49,18 @@ default String name() {
*/
TableScan newScan();
+ /**
+ * Create a new {@link TableScan scan} for this table with a {@link
MetricsReporter metrics
+ * reporter}.
+ *
+ * <p>Once a table scan is created, it can be refined to project columns and
filter data.
+ *
+ * @return a table scan for this table
+ */
+ default TableScan newScan(MetricsReporter metricsReporter) {
Review Comment:
Instead of modifying `Table`, we should probably extend `Scan` to accept any
number of custom metrics reporters in addition to the default one. It should
behave like a listener pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
