szehon-ho commented on code in PR #6698: URL: https://github.com/apache/iceberg/pull/6698#discussion_r1136300237
########## hive-metastore/src/main/java/org/apache/iceberg/hive/CachedClientPool.java: ########## @@ -53,12 +70,14 @@ public class CachedClientPool implements ClientPool<IMetaStoreClient, TException properties, CatalogProperties.CLIENT_POOL_CACHE_EVICTION_INTERVAL_MS, CatalogProperties.CLIENT_POOL_CACHE_EVICTION_INTERVAL_MS_DEFAULT); + this.keySuppliers = Review Comment: Thanks, my thought is, lets keep it simple until we have some use case where a process start sharing the HiveCatalog. I dont see any huge problem just creating one on the fly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org