szehon-ho commented on code in PR #6698: URL: https://github.com/apache/iceberg/pull/6698#discussion_r1133002687
########## core/src/main/java/org/apache/iceberg/CatalogProperties.java: ########## @@ -119,6 +119,26 @@ private CatalogProperties() {} "client.pool.cache.eviction-interval-ms"; public static final long CLIENT_POOL_CACHE_EVICTION_INTERVAL_MS_DEFAULT = TimeUnit.MINUTES.toMillis(5); + /** + * A comma separated list of elements that are used to compose the key of the client pool cache. + * + * <p>The following elements are supported: + * + * <ul> + * <li>URI - as specified by {@link CatalogProperties#URI}. URI will be the only element when Review Comment: @lirui-apache I went through the discussion, couldn't find the relevant information, could you summarize when do we not want to use UGI as part of the key? When we want to re-use the client pool despite UGI being not equal()? I saw mainly the discussion was about UGI not implementing equality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org